Beta
×

Welcome to the Slashdot Beta site -- learn more here. Use the link in the footer or click here to return to the Classic version of Slashdot.

Thank you!

Before you choose to head back to the Classic look of the site, we'd appreciate it if you share your thoughts on the Beta; your feedback is what drives our ongoing development.

Beta is different and we value you taking the time to try it out. Please take a look at the changes we've made in Beta and  learn more about it. Thanks for reading, and for making the site better!

Ask Slashdot: How do I deal w/ a coworker who keeps telling me I write bad code

Anonymous Coward writes | about a year and a half ago

Programming 2

An anonymous reader writes "I have been with my company for 10+ years and have seen many development cycles on our projects. We have a developer intern who has not been on the team for very long. On day one he started ripping into my code on how terrible it is. We have a code base of roughly 50,000 lines of code. When he comes to me with a complaint about the code it is simply because he does not have the experience with it to actually understand what the code is doing. He is a smart guy with lots of promise, he is asking good questions, but how do I get him to look past his own self perceived greatness enough to slow down and learn what we are doing and how we have pulled it off?"

cancel ×

2 comments

Sorry! There are no comments related to the filter you selected.

here's a pail and a mop (1)

jfalcon (163956) | about a year and a half ago | (#42467931)

Have him comment the code base. All code is sorely lacking in documentation and commentary.

When the comments are part of the docs (like doxygen), then it will matter if the document doesn't read correctly as to what function does what and it will be apparent if he understands what occurs. If he does a good job writing it up, then invite him to be part of a harder problem.

Simple: prove him wrong (1)

gnu-sucks (561404) | about a year and a half ago | (#42468445)

Just prove him wrong. Ask him why he thinks your code is so bad. Maybe he's right, probably not though, and his argument will fall apart once you show him how your code works and why you did it the way you did. Be patient so long as he is reasonable and maybe you'll both learn something.

On the other hand, if he doesn't calm down about it, get mean.

Check for New Comments
Slashdot Login

Need an Account?

Forgot your password?

Submission Text Formatting Tips

We support a small subset of HTML, namely these tags:

  • b
  • i
  • p
  • br
  • a
  • ol
  • ul
  • li
  • dl
  • dt
  • dd
  • em
  • strong
  • tt
  • blockquote
  • div
  • quote
  • ecode

"ecode" can be used for code snippets, for example:

<ecode>    while(1) { do_something(); } </ecode>